hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12564) Upgrade JUnit3 TestCase to JUnit 4 for tests of org.apache.hadoop.io package
Date Sat, 14 Nov 2015 07:36:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005232#comment-15005232

Tsuyoshi Ozawa commented on HADOOP-12564:

[~cote] Thank you for updating. We're almost there. In addition to Akira's comment, please
check following comments:

  public void testCreateWriterOnExistingFile() throws IOException {
Please fix indentation(Please remote single whitespace before Test annotation).

  public void testVLong6Bytes() throws IOException {
  public void testVLong7Bytes() throws IOException {
  public void testVLong8Bytes() throws IOException {
  public void testVLongRandom() throws IOException {
Please add a line break between each test cases because of consistent coding style.

import org.junit.After;
import org.junit.Before;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;

Please remove unused imports.

> Upgrade JUnit3 TestCase to JUnit 4 for tests of org.apache.hadoop.io package
> ----------------------------------------------------------------------------
>                 Key: HADOOP-12564
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12564
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Dustin Cote
>            Assignee: Dustin Cote
>            Priority: Trivial
>         Attachments: MAPREDUCE-6505-1.patch, MAPREDUCE-6505-2.patch, MAPREDUCE-6505-3.patch,
MAPREDUCE-6505-4.patch, MAPREDUCE-6505-5.patch
> Migrating just the io test cases 

This message was sent by Atlassian JIRA

View raw message