Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD3341851F for ; Sun, 11 Oct 2015 22:36:05 +0000 (UTC) Received: (qmail 53922 invoked by uid 500); 11 Oct 2015 22:36:05 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 53866 invoked by uid 500); 11 Oct 2015 22:36:05 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 53729 invoked by uid 99); 11 Oct 2015 22:36:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Oct 2015 22:36:05 +0000 Date: Sun, 11 Oct 2015 22:36:05 +0000 (UTC) From: "Gera Shegalov (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12469) distcp shout not ignore the ignoreFailures option MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952469#comment-14952469 ] Gera Shegalov commented on HADOOP-12469: ---------------------------------------- Hi [~liuml07], thanks for working on the patch. Regarding the unit test you should consider a full distcp test where you create a file and make it unusable by setting 000 permission. DistCp should be run doAs non-cluster-root user. bq. Should we address the orthogonal ignoreFailures mutually exclusive with the atomic option separately? Sure, will you file it? > distcp shout not ignore the ignoreFailures option > ------------------------------------------------- > > Key: HADOOP-12469 > URL: https://issues.apache.org/jira/browse/HADOOP-12469 > Project: Hadoop Common > Issue Type: Bug > Components: tools/distcp > Affects Versions: 2.7.1 > Reporter: Gera Shegalov > Assignee: Mingliang Liu > Priority: Critical > Fix For: 2.8.0 > > Attachments: HADOOP-12469.000.patch > > > {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via > # via {{RetriableCommand::execute}} > # via {{CopyMapper#copyFileWithRetry}} > before {{CopyMapper::handleFailure}} tests > {code} > if (ignoreFailures && exception.getCause() instanceof > RetriableFileCopyCommand.CopyReadException > {code} > which is always false. > Orthogonally, ignoring failures should be mutually exclusive with the atomic option otherwise an incomplete dir is eligible for commit defeating the purpose. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)