Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 2 Oct 2015 07:09:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12840717.1435282942000.8551.1443769767442@Atlassian.JIRA>
In-Reply-To: <JIRA.12840717.1435282942000@Atlassian.JIRA>
References: <JIRA.12840717.1435282942000@Atlassian.JIRA>
 <JIRA.12840717.1435282942490@arcas>
Subject: [jira] [Commented] (HADOOP-12122) Hadoop should avoid unsafe split
 and append on fields that might be IPv6 literals
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940840#comment-14940840 ] 

Hadoop QA commented on HADOOP-12122:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  20m 20s | Findbugs (version 3.0.0) appears to be broken on HADOOP-11890. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 11 new or modified test files. |
| {color:green}+1{color} | javac |   7m 44s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 23s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 26s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   4m 10s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  9s | The patch has 2  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 48s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |  13m 54s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |  19m 57s | Tests failed in hadoop-common. |
| {color:green}+1{color} | yarn tests |   2m 47s | Tests passed in hadoop-yarn-common. |
| {color:green}+1{color} | yarn tests |   0m 41s | Tests passed in hadoop-yarn-server-common. |
| {color:red}-1{color} | yarn tests |  10m 56s | Tests failed in hadoop-yarn-server-nodemanager. |
| {color:green}+1{color} | yarn tests |  60m 32s | Tests passed in hadoop-yarn-server-resourcemanager. |
| {color:green}+1{color} | yarn tests |   0m 32s | Tests passed in hadoop-yarn-server-web-proxy. |
| {color:red}-1{color} | hdfs tests | 104m 14s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 32s | Tests passed in hadoop-hdfs-client. |
| | | 259m 45s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.fs.contract.rawlocal.TestRawlocalContractDelete |
|   | hadoop.fs.contract.localfs.TestLocalFSContractOpen |
|   | hadoop.fs.contract.localfs.TestLocalFSContractRename |
|   | hadoop.fs.contract.localfs.TestLocalFSContractDelete |
|   | hadoop.security.ssl.TestSSLFactory |
|   | hadoop.fs.contract.localfs.TestLocalFSContractCreate |
|   | hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics |
|   | hadoop.hdfs.server.blockmanagement.TestBlockManager |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement |
| Timed out tests | org.apache.hadoop.conf.TestConfiguration |
|   | org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations |
|   | org.apache.hadoop.hdfs.server.mover.TestStorageMover |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12764724/HADOOP-12122-HADOOP-11890.0.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HADOOP-11890 / 6f61143 |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/whitespace.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-common.txt |
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-yarn-common.txt |
| hadoop-yarn-server-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| hadoop-yarn-server-web-proxy test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/artifact/patchprocess/testrun_hadoop-hdfs-client.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7754/console |


This message was automatically generated.

> Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-12122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12122
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HADOOP-11890
>            Reporter: Nate Edel
>            Assignee: Nate Edel
>         Attachments: HADOOP-12122-HADOOP-11890.0.patch, HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch
>
>
> There are a fairly extensive number of locations found via code inspection which use unsafe methods of handling addresses in a dual-stack or IPv6-only world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the above.
> This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString() with a wrapper that properly brackets the IPv6 address if there is one.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)