Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 14 Oct 2015 07:30:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12840717.1435282942000.33875.1444807805774@Atlassian.JIRA>
In-Reply-To: <JIRA.12840717.1435282942000@Atlassian.JIRA>
References: <JIRA.12840717.1435282942000@Atlassian.JIRA>
 <JIRA.12840717.1435282942490@arcas>
Subject: [jira] [Commented] (HADOOP-12122) Fix Hadoop should avoid unsafe
 split and append on fields that might be IPv6 literals
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956426#comment-14956426 ] 

Hadoop QA commented on HADOOP-12122:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  22m 37s | Findbugs (version 3.0.0) appears to be broken on HADOOP-11890. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 16 new or modified test files. |
| {color:green}+1{color} | javac |   7m 50s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 10s | There were no new javadoc warning messages. |
| {color:red}-1{color} | release audit |   0m 15s | The applied patch generated 1 release audit warnings. |
| {color:red}-1{color} | checkstyle |   3m 33s | The applied patch generated  6 new checkstyle issues (total was 339, now 345). |
| {color:red}-1{color} | checkstyle |   4m 34s | The applied patch generated  2 new checkstyle issues (total was 51, now 52). |
| {color:red}-1{color} | whitespace |   0m 27s | The patch has 4  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 41s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:red}-1{color} | findbugs |  15m 35s | The patch appears to introduce 7 new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   7m 37s | Tests failed in hadoop-common. |
| {color:green}+1{color} | mapreduce tests |   1m 46s | Tests passed in hadoop-mapreduce-client-core. |
| {color:green}+1{color} | mapreduce tests |   5m 52s | Tests passed in hadoop-mapreduce-client-hs. |
| {color:red}-1{color} | mapreduce tests | 100m 42s | Tests failed in hadoop-mapreduce-client-jobclient. |
| {color:green}+1{color} | yarn tests |   2m  5s | Tests passed in hadoop-yarn-common. |
| {color:green}+1{color} | yarn tests |   0m 30s | Tests passed in hadoop-yarn-server-common. |
| {color:red}-1{color} | yarn tests |   8m 31s | Tests failed in hadoop-yarn-server-nodemanager. |
| {color:red}-1{color} | yarn tests |  55m 37s | Tests failed in hadoop-yarn-server-resourcemanager. |
| {color:green}+1{color} | yarn tests |   0m 29s | Tests passed in hadoop-yarn-server-web-proxy. |
| {color:red}-1{color} | hdfs tests |   0m 30s | Tests failed in hadoop-hdfs. |
| {color:red}-1{color} | hdfs tests |   0m 26s | Tests failed in hadoop-hdfs-client. |
| | | 249m 10s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-client |
| Failed unit tests | hadoop.crypto.key.TestValueQueue |
|   | hadoop.mapred.TestNetworkedJob |
|   | hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels |
|   | hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart |
| Timed out tests | org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore |
| Failed build | hadoop-hdfs |
|   | hadoop-hdfs-client |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12766458/HADOOP-12122-HADOOP-11890.6.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HADOOP-11890 / f33be9a |
| Release Audit | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/patchReleaseAuditProblems.txt |
| checkstyle |  https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/whitespace.txt |
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-common.txt |
| hadoop-mapreduce-client-core test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt |
| hadoop-mapreduce-client-hs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt |
| hadoop-mapreduce-client-jobclient test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt |
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-yarn-common.txt |
| hadoop-yarn-server-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt |
| hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| hadoop-yarn-server-web-proxy test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/artifact/patchprocess/testrun_hadoop-hdfs-client.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7809/console |


This message was automatically generated.

> Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12122
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HADOOP-11890
>            Reporter: Nate Edel
>            Assignee: Nemanja Matkovic
>         Attachments: HADOOP-12122-HADOOP-11890.0.patch, HADOOP-12122-HADOOP-11890.3.patch, HADOOP-12122-HADOOP-11890.4.patch, HADOOP-12122-HADOOP-11890.5.patch, HADOOP-12122-HADOOP-11890.6.patch, HADOOP-12122-HADOOP-12122.2.patch, HADOOP-12122-HADOOP-12122.3.patch, HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch
>
>
> There are a fairly extensive number of locations found via code inspection which use unsafe methods of handling addresses in a dual-stack or IPv6-only world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the above.
> This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString() with a wrapper that properly brackets the IPv6 address if there is one.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)