Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 05C8718CE2 for ; Fri, 2 Oct 2015 17:07:28 +0000 (UTC) Received: (qmail 62091 invoked by uid 500); 2 Oct 2015 17:07:27 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 62041 invoked by uid 500); 2 Oct 2015 17:07:27 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 62028 invoked by uid 99); 2 Oct 2015 17:07:27 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Oct 2015 17:07:27 +0000 Date: Fri, 2 Oct 2015 17:07:27 +0000 (UTC) From: "Elliott Clark (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-12122) Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HADOOP-12122: ----------------------------------- Summary: Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals (was: Hadoop should avoid unsafe split and append on fields that might be IPv6 literals) > Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals > ------------------------------------------------------------------------------------- > > Key: HADOOP-12122 > URL: https://issues.apache.org/jira/browse/HADOOP-12122 > Project: Hadoop Common > Issue Type: Sub-task > Affects Versions: HADOOP-11890 > Reporter: Nate Edel > Assignee: Nate Edel > Attachments: HADOOP-12122-HADOOP-11890.0.patch, HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch > > > There are a fairly extensive number of locations found via code inspection which use unsafe methods of handling addresses in a dual-stack or IPv6-only world: > - splits on the first ":" assuming that delimits a host from a port > - produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which is the standard for IPv6 URIs) > - depends on the behavior of InetSocketAddress.toString() which produces the above. > This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString() with a wrapper that properly brackets the IPv6 address if there is one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)