Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDC4418B2C for ; Sat, 31 Oct 2015 03:59:28 +0000 (UTC) Received: (qmail 74265 invoked by uid 500); 31 Oct 2015 03:59:28 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 74215 invoked by uid 500); 31 Oct 2015 03:59:28 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 74174 invoked by uid 99); 31 Oct 2015 03:59:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2015 03:59:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C8CD22C1F56 for ; Sat, 31 Oct 2015 03:59:27 +0000 (UTC) Date: Sat, 31 Oct 2015 03:59:27 +0000 (UTC) From: "Allen Wittenauer (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HADOOP-10787) Rename/remove non-HADOOP_*, etc from the shell scripts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983792#comment-14983792 ] Allen Wittenauer edited comment on HADOOP-10787 at 10/31/15 3:58 AM: --------------------------------------------------------------------- OK, I see the bug here too. I'll fix it... was (Author: aw): bq. hadoop_add_common_to_classpath I just noticed this; these are the existing tests and not touched by this patch. So the current tests don't work on your machine (for some reason). What's your default shell? I wonder if it's not using bash to actually execute things. The code that's not working is: {code} for j in HADOOP_CLASSPATH \ HADOOP_ENABLE_BUILD_PATHS \ CLASSPATH HADOOP_COMMON_DIR \ HADOOP_COMMON_HOME \ HADOOP_COMMON_LIB_JARS_DIR \ HADOOP_ENABLE_BUILD_PATHS ; do unset ${!j} done {code} ... which is pretty unremarkable. > Rename/remove non-HADOOP_*, etc from the shell scripts > ------------------------------------------------------ > > Key: HADOOP-10787 > URL: https://issues.apache.org/jira/browse/HADOOP-10787 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts > Affects Versions: 3.0.0 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Priority: Blocker > Labels: scripts > Attachments: HADOOP-10787.00.patch, HADOOP-10787.01.patch, HADOOP-10787.02.patch, HADOOP-10787.03.patch, HADOOP-10787.04.patch > > > We should make an effort to clean up the shell env var name space by removing unsafe variables. See comments for list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)