hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12514) Make static fields in GenericTestUtils for assertExceptionContains() package-private and final
Date Wed, 28 Oct 2015 14:14:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978481#comment-14978481
] 

Hudson commented on HADOOP-12514:
---------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #607 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/607/])
HADOOP-12514. Make static fields in GenericTestUtils for  (stevel: rev a04b16970b0dbe903ac9a3a2a3080cf6de181bc2)
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> Make static fields in GenericTestUtils for assertExceptionContains() package-private
and final
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12514
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12514
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: test
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12514.000.patch
>
>
> This is a follow up of [HADOOP-12472].
> It makes sense to make the following static fields package private instead of protected,
as they are for test purpose and {{TestGenericTestUtils}} is in the same package as {{GenericTestUtils}}.
> -  protected static String E_NULL_THROWABLE = "Null Throwable";
> -  protected static String E_NULL_THROWABLE_STRING = "Null Throwable.toString() value";
> -  protected static String E_UNEXPECTED_EXCEPTION = "but got unexpected exception";
> Meanwhile, we may need to make them final.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message