hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12472) Make GenericTestUtils.assertExceptionContains robust
Date Mon, 26 Oct 2015 21:04:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975057#comment-14975057
] 

Andrew Wang commented on HADOOP-12472:
--------------------------------------

We could make the static strings package-private and final right? Otherwise LGTM, +1 pending
that.

> Make GenericTestUtils.assertExceptionContains robust
> ----------------------------------------------------
>
>                 Key: HADOOP-12472
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12472
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-12472-001.patch
>
>
> {{GenericTestUtils.assertExceptionContains}} calls {{Exception.getMessage()}}, followed
by msg.contains().
> This will NPE for an exception with a null message, such as NPE.
> # it should call toString()
> # and do an assertNotNull on the result in case some subclass does something very bad
> # and for safety, check the asser



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message