hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12122) Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
Date Thu, 15 Oct 2015 22:36:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959762#comment-14959762
] 

Elliott Clark commented on HADOOP-12122:
----------------------------------------

Comments on TestNetUtils are just wrong.
pom.xml still turns off ipv6 wouldn't allowing ipv6 stack make the tests more representative?
It should fully work now correct?
Comment IPCLoggerChannel why is it doing the dance of ip instanceof Inet6Address?
DatanodeManager talks about BasicInetPeer why not just change that?
Checkpointer seems like that's still not very elegant code. Is there something better ?
HostUtil creates a logger and never uses it. Remove it if it's not going to be needed.
ConverterUtils' logger looks really weird.
NetUtils' javadoc seems weird. Why add an extra line that says basically the same thing to
a single method?

> Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12122
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HADOOP-11890
>            Reporter: Nate Edel
>            Assignee: Nemanja Matkovic
>         Attachments: HADOOP-12122-HADOOP-11890.0.patch, HADOOP-12122-HADOOP-11890.3.patch,
HADOOP-12122-HADOOP-11890.4.patch, HADOOP-12122-HADOOP-11890.5.patch, HADOOP-12122-HADOOP-11890.6.patch,
HADOOP-12122-HADOOP-11890.7.patch, HADOOP-12122-HADOOP-11890.8.patch, HADOOP-12122-HADOOP-12122.2.patch,
HADOOP-12122-HADOOP-12122.3.patch, HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch
>
>
> There are a fairly extensive number of locations found via code inspection which use
unsafe methods of handling addresses in a dual-stack or IPv6-only world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which
is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the above.
> This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString()
with a wrapper that properly brackets the IPv6 address if there is one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message