hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nemanja Matkovic (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12122) Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
Date Wed, 14 Oct 2015 17:14:05 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Nemanja Matkovic updated HADOOP-12122:
    Attachment: HADOOP-12122-HADOOP-11890.7.patch

Fixed whitespace, ran all QA bot failed tests locally on HADOOP-11890 branch both before any
changes came in (head 439f43ad3defbac907eda2d139a793f153544430) and after all patches, this
is what I see:
  1. TestNetworkedJob --> Failed with same error in both heads
  2. TestNodestatusUpdaterForLabels --> Passes locally in both setups, probably flaky test?
  3. TestAMRestart class of tests --> In QABot all failed with NoClassDefFound, locally
all are passing in both heads.
   4. Fake build breaks are still here.

> Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals
> -------------------------------------------------------------------------------------
>                 Key: HADOOP-12122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12122
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HADOOP-11890
>            Reporter: Nate Edel
>            Assignee: Nemanja Matkovic
>         Attachments: HADOOP-12122-HADOOP-11890.0.patch, HADOOP-12122-HADOOP-11890.3.patch,
HADOOP-12122-HADOOP-11890.4.patch, HADOOP-12122-HADOOP-11890.5.patch, HADOOP-12122-HADOOP-11890.6.patch,
HADOOP-12122-HADOOP-11890.7.patch, HADOOP-12122-HADOOP-12122.2.patch, HADOOP-12122-HADOOP-12122.3.patch,
HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch
> There are a fairly extensive number of locations found via code inspection which use
unsafe methods of handling addresses in a dual-stack or IPv6-only world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which
is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the above.
> This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString()
with a wrapper that properly brackets the IPv6 address if there is one.

This message was sent by Atlassian JIRA

View raw message