hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
Date Fri, 09 Oct 2015 03:00:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949808#comment-14949808
] 

Hudson commented on HADOOP-11104:
---------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8598 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8598/])
HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75)
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java


> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-11104
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11104
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>            Priority: Minor
>              Labels: newbie, supportability
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, HADOOP-11104.003.patch,
HADOOP-11104.004.patch, HADOOP-11104.005.patch
>
>
> Passing a negative value to the interval field of MetricsRegistry#newQuantiles should
throw a MetricsException with a clear error message.  The current stack trace looks something
like:
> java.lang.IllegalArgumentException: null
>         at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
>         at org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
>         at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like MetricsRegistry#newCounter() also
have parameter checking for negative int/long values?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message