hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ray Chiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
Date Thu, 01 Oct 2015 18:55:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940228#comment-14940228

Ray Chiang commented on HADOOP-11104:

RE: Release audit

"Missing Apache header" in /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/CHANGES-HDFS-EC-7285.txt.
 This patch does not modify this file.

RE: Failed unit tests

Both tests pass in my tree.

> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
> ---------------------------------------------------------------------------------
>                 Key: HADOOP-11104
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11104
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>            Priority: Minor
>              Labels: BB2015-05-TBR, newbie, supportability
>         Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, HADOOP-11104.003.patch,
> Passing a negative value to the interval field of MetricsRegistry#newQuantiles should
throw a MetricsException with a clear error message.  The current stack trace looks something
> java.lang.IllegalArgumentException: null
>         at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
>         at org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
>         at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like MetricsRegistry#newCounter() also
have parameter checking for negative int/long values?

This message was sent by Atlassian JIRA

View raw message