hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-10787) Rename/remove non-HADOOP_*, etc from the shell scripts
Date Sat, 31 Oct 2015 03:59:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983792#comment-14983792
] 

Allen Wittenauer edited comment on HADOOP-10787 at 10/31/15 3:58 AM:
---------------------------------------------------------------------

OK, I see the bug here too. I'll fix it...


was (Author: aw):
bq. hadoop_add_common_to_classpath

I just noticed this; these are the existing tests and not touched by this patch.  So the current
tests don't work on your machine (for some reason).  What's your default shell? I wonder if
it's not using bash to actually execute things.  

The code that's not working is:

{code}
  for j in HADOOP_CLASSPATH  \
        HADOOP_ENABLE_BUILD_PATHS \
        CLASSPATH HADOOP_COMMON_DIR \
        HADOOP_COMMON_HOME \
        HADOOP_COMMON_LIB_JARS_DIR \
        HADOOP_ENABLE_BUILD_PATHS ; do
      unset ${!j}
  done
{code}

... which is pretty unremarkable.

> Rename/remove non-HADOOP_*, etc from the shell scripts
> ------------------------------------------------------
>
>                 Key: HADOOP-10787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10787
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>              Labels: scripts
>         Attachments: HADOOP-10787.00.patch, HADOOP-10787.01.patch, HADOOP-10787.02.patch,
HADOOP-10787.03.patch, HADOOP-10787.04.patch
>
>
> We should make an effort to clean up the shell env var name space by removing unsafe
variables.  See comments for list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message