hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found
Date Thu, 08 Oct 2015 18:23:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949090#comment-14949090
] 

Steve Loughran commented on HADOOP-10775:
-----------------------------------------

checkstyle
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:675:
First sentence should end with a period.
{code}

common test failure
{code}
org.apache.hadoop.net.TestDNS.testLookupWithoutHostsFallback

java.lang.AssertionError: 
Expected: is "-DUMMY_HOSTNAME"
     but: was "localhost"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.Assert.assertThat(Assert.java:832)
	at org.apache.hadoop.net.TestDNS.testLookupWithoutHostsFallback(TestDNS.java:224)
Standard Output

2015-10-06 21:52:38,228 WARN  net.DNS (DNS.java:getHosts(268)) - Unable to determine hostname
for interface lo
2015-10-06 21:52:38,239 WARN  net.DNS (DNS.java:getHosts(268)) - Unable to determine hostname
for interface lo
2015-10-06 21:52:38,296 INFO  net.TestDNS (TestDNS.java:testRDNS(168)) - Local revers DNS
hostname is asf900.gq1.ygridcore.net
2015-10-06 21:52:38,298 INFO  net.TestDNS (TestDNS.java:testLocalhostResolves(261)) - Localhost
IPAddr is localhost/127.0.0.1
2015-10-06 21:52:38,355 WARN  net.DNS (DNS.java:getHosts(268)) - Unable to determine hostname
for interface lo
2015-10-06 21:52:38,403 WARN  net.DNS (DNS.java:getHosts(268)) - Unable to determine hostname
for interface lo
{code}

> Shell operations to fail with meaningful errors on windows if winutils.exe not found
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10775
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: trunk-win, 2.7.1
>         Environment: windows
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, HADOOP-10775-004.patch,
HADOOP-10775-005.patch, HADOOP-10775-006.patch, HADOOP-10775-007.patch, HADOOP-10775-008.patch,
HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other causes, then
an error is logged -but when any of the {{Shell}} operations are used, an NPE is raised rather
than something meaningful.
> The error message at setup time should be preserved and then raised before any attempt
to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message