Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 31C6D18BD1 for ; Fri, 11 Sep 2015 05:04:46 +0000 (UTC) Received: (qmail 45337 invoked by uid 500); 11 Sep 2015 05:04:46 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 45290 invoked by uid 500); 11 Sep 2015 05:04:45 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 45277 invoked by uid 99); 11 Sep 2015 05:04:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 05:04:45 +0000 Date: Fri, 11 Sep 2015 05:04:45 +0000 (UTC) From: "Jagadesh Kiran N (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12401) Wrong function names in test-patch bigtop personality MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740191#comment-14740191 ] Jagadesh Kiran N commented on HADOOP-12401: ------------------------------------------- [~sekikn] ,any conclusion, these functions need to be renamend, removed or commented , please let me know, so that i can share a patch for the same > Wrong function names in test-patch bigtop personality > ----------------------------------------------------- > > Key: HADOOP-12401 > URL: https://issues.apache.org/jira/browse/HADOOP-12401 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Affects Versions: HADOOP-12111 > Reporter: Kengo Seki > > In dev-support/personality/bigtop.sh: > {code} > 51 function bigtop_precheck_postinstall > 52 { > 53 if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then > 54 pushd "${BASEDIR}" >/dev/null > 55 echo_and_redirect "${PATCH_DIR}/bigtop-branch-toolchain.txt" "${GRADLEW}" toolchain > 56 popd >/dev/null > 57 fi > 58 } > 59 > 60 function bigtop_postapply_postinstall > 61 { > 62 if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then > 63 pushd "${BASEDIR}" >/dev/null > 64 echo_and_redirect "${PATCH_DIR}/bigtop-patch-toolchain.txt" "${GRADLEW}" toolchain > 65 popd >/dev/null > 66 fi > 67 } > {code} > Their names are not proper for test-patch plugin callback functions. Maybe it should be like: > {code} > function bigtop_precompile > { > declare codebase=$1 > if [[ ${BIGTOP_PUPPETSETUP} = "true" && ( ${codebase} = "branch" || ${codebase} = "patch" ) ]]; then > pushd "${BASEDIR}" >/dev/null > echo_and_redirect "${PATCH_DIR}/bigtop-${codebase}-toolchain.txt" "${GRADLEW}" toolchain > popd >/dev/null > fi > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)