Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4747017D2B for ; Fri, 11 Sep 2015 00:22:51 +0000 (UTC) Received: (qmail 9581 invoked by uid 500); 11 Sep 2015 00:22:46 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 9531 invoked by uid 500); 11 Sep 2015 00:22:46 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 9466 invoked by uid 99); 11 Sep 2015 00:22:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 00:22:46 +0000 Date: Fri, 11 Sep 2015 00:22:45 +0000 (UTC) From: "Robert Kanter (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12348) MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739906#comment-14739906 ] Robert Kanter commented on HADOOP-12348: ---------------------------------------- +1 LGTM > MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. > ------------------------------------------------------------------------------ > > Key: HADOOP-12348 > URL: https://issues.apache.org/jira/browse/HADOOP-12348 > Project: Hadoop Common > Issue Type: Bug > Components: metrics > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: HADOOP-12348.000.patch, HADOOP-12348.001.patch > > > MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond for jmxCacheTTL but MetricsSystemImpl passes time unit second to MetricsSourceAdapter constructor. > {code} > jmxCacheTS = Time.now() + jmxCacheTTL; > /** > * Current system time. Do not use this to calculate a duration or interval > * to sleep, because it will be broken by settimeofday. Instead, use > * monotonicNow. > * @return current time in msec. > */ > public static long now() { > return System.currentTimeMillis(); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)