hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12374) Description of hdfs expunge command is confusing
Date Tue, 08 Sep 2015 02:27:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734148#comment-14734148
] 

Weiwei Yang commented on HADOOP-12374:
--------------------------------------

Hi [~templedf] 

Thank you so much for the comments, I get your point and it makes sense to me. My intention
was to keep the phrasing simple and clear (like rest of docs), and give an extra link to elaborate
how it works. I contributed another patch to improve the document (see HADOOP-5323), it explains
checkpoints, those parameters and details about trash feature. So user can go to [http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes].
Note the link directly points to *File Deletes and Undeletes*, user doesn't need to search.

So based on that, can we document the expunge command like below ? 

+If trash feature is enabled, HDFS moves deleted files to a trash directory and creates checkpoints
in a configurable interval, this command finds those expired checkpoints (exists more than
fs.trash.interval) and remove them from the file system.+

> Description of hdfs expunge command is confusing
> ------------------------------------------------
>
>                 Key: HADOOP-12374
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12374
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation, trash
>    Affects Versions: 2.7.0, 2.7.1
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Trivial
>              Labels: docuentation, newbie, suggestions, trash
>         Attachments: HADOOP-12374.001.patch
>
>
> Usage: hadoop fs -expunge
> Empty the Trash. Refer to the HDFS Architecture Guide for more information on the Trash
feature.
> this description is confusing. It gives user the impression that this command will empty
trash, but actually it only removes old checkpoints. If user sets a pretty long value for
fs.trash.interval, this command will not remove anything until checkpoints exist longer than
this value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message