hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12348) MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
Date Sat, 12 Sep 2015 00:46:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741795#comment-14741795
] 

Hudson commented on HADOOP-12348:
---------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #1113 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1113/])
HADOOP-12348. MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
(zxu via rkanter) (rkanter: rev 9538af0e1a7428b8787afa8d5e0b82c1e04adca7)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-12348
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12348
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12348.000.patch, HADOOP-12348.001.patch, HADOOP-12348.branch-2.patch
>
>
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter
expects time unit millisecond  for jmxCacheTTL but MetricsSystemImpl  passes time unit second
to MetricsSourceAdapter constructor.
> {code}
>         jmxCacheTS = Time.now() + jmxCacheTTL;
>   /**
>    * Current system time.  Do not use this to calculate a duration or interval
>    * to sleep, because it will be broken by settimeofday.  Instead, use
>    * monotonicNow.
>    * @return current time in msec.
>    */
>   public static long now() {
>     return System.currentTimeMillis();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message