hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11918) Listing an empty s3a root directory throws FileNotFound.
Date Sat, 19 Sep 2015 00:18:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876732#comment-14876732
] 

Chris Nauroth commented on HADOOP-11918:
----------------------------------------

Thank you, [~eddyxu] and [~Thomas Demoor].  Patch v003 looks good to me aside from a few minor
nit-picks.

{code}
    for (FileStatus status : statuses) {
     assertEquals("Could not remove files from root", true,
         fs.delete(status.getPath(), true));
    }
{code}

Indentation is slightly off for the {{assertEquals}} line inside the loop.

{code}
        if (LOG.isDebugEnabled()) {
          LOG.debug("Found root directory");
        }
{code}

There is no need to check {{isDebugEnabled}}, because there is no expensive string concatenation
logic to build the log message.  It's just a string literal.

I ran {{TestS3AContractRootDir}} against my own testing S3 bucket, and it passed.  It appears
earlier feedback has been addressed too.

I'll be +1 after the nit-picks are fixed.  [~stevel@apache.org], please let us know if you
have any other thoughts on the patch.

> Listing an empty s3a root directory throws FileNotFound.
> --------------------------------------------------------
>
>                 Key: HADOOP-11918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11918
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 2.7.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>              Labels: BB2015-05-TBR, s3
>         Attachments: HADOOP-11918-002.patch, HADOOP-11918-003.patch, HADOOP-11918.000.patch,
HADOOP-11918.001.patch
>
>
> With an empty s3 bucket and run
> {code}
> $ hadoop fs -D... -ls s3a://hdfs-s3a-test/
> 15/05/04 15:21:34 WARN util.NativeCodeLoader: Unable to load native-hadoop library for
your platform... using builtin-java classes where applicable
> ls: `s3a://hdfs-s3a-test/': No such file or directory
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message