hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12428) Fix inconsistency between log-level guards and statements
Date Tue, 22 Sep 2015 08:50:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902242#comment-14902242
] 

Hudson commented on HADOOP-12428:
---------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #402 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/402/])
HADOOP-12428. Fix inconsistency between log-level guards and statements. Contributed by Jagadesh
Kiran N and Jackie Chang. (ozawa: rev dfd807afab0fae3839c9cc5d552aa0304444f956)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupImage.java
* hadoop-mapreduce-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
* hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/UniformSizeInputFormat.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/NMTokenSelector.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/ContainerTokenSelector.java
* hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SerialJobFactory.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerRequestor.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java


> Fix inconsistency between log-level guards and statements
> ---------------------------------------------------------
>
>                 Key: HADOOP-12428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12428
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jackie Chang
>            Assignee: Jagadesh Kiran N
>            Priority: Minor
>              Labels: BB2015-05-TBR
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-9995-00.patch, HADOOP-9995.patch, MAPREDUCE-6468-01.patch,
MAPREDUCE-6468-02.patch, MAPREDUCE-6468-03.patch, MAPREDUCE-6468-04.patch
>
>
> Developers use logs to do in-house debugging. These log statements are later demoted
to less severe levels and usually are guarded by their matching severity levels. However,
we do see inconsistencies in trunk. A log statement like 
> {code}
>        if (LOG.isDebugEnabled()) {
>         LOG.info("Assigned container (" + allocated + ") "
> {code}
> doesn't make much sense because the log message is actually only printed out in DEBUG-level.
We do see previous issues tried to correct this inconsistency. I am proposing a comprehensive
correction over trunk.
> Doug Cutting pointed it out in HADOOP-312: https://issues.apache.org/jira/browse/HADOOP-312?focusedCommentId=12429498&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12429498
> HDFS-1611 also corrected this inconsistency.
> This could have been avoided by switching from log4j to slf4j's {} format like CASSANDRA-625
(2010/3) and ZOOKEEPER-850 (2012/1), which gives cleaner code and slightly higher performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message