Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Sat, 29 Aug 2015 03:55:45 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12858042.1440228194000.201158.1440820545885@Atlassian.JIRA>
In-Reply-To: <JIRA.12858042.1440228194000@Atlassian.JIRA>
References: <JIRA.12858042.1440228194000@Atlassian.JIRA>
 <JIRA.12858042.1440228194117@arcas>
Subject: [jira] [Commented] (HADOOP-12348) MetricsSystemImpl creates
 MetricsSourceAdapter with wrong time unit parameter.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720957#comment-14720957 ] 

Hadoop QA commented on HADOOP-12348:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  19m 49s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 48s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 56s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 12s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 51s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  22m 34s | Tests passed in hadoop-common. |
| | |  65m 40s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753113/HADOOP-12348.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e2c9b28 |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7551/console |


This message was automatically generated.

> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-12348
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12348
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: HADOOP-12348.000.patch, HADOOP-12348.001.patch
>
>
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond  for jmxCacheTTL but MetricsSystemImpl  passes time unit second to MetricsSourceAdapter constructor.
> {code}
>         jmxCacheTS = Time.now() + jmxCacheTTL;
>   /**
>    * Current system time.  Do not use this to calculate a duration or interval
>    * to sleep, because it will be broken by settimeofday.  Instead, use
>    * monotonicNow.
>    * @return current time in msec.
>    */
>   public static long now() {
>     return System.currentTimeMillis();
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)