Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD9AB18865 for ; Thu, 13 Aug 2015 12:06:48 +0000 (UTC) Received: (qmail 75832 invoked by uid 500); 13 Aug 2015 12:06:48 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 75789 invoked by uid 500); 13 Aug 2015 12:06:48 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 75774 invoked by uid 99); 13 Aug 2015 12:06:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 12:06:48 +0000 Date: Thu, 13 Aug 2015 12:06:48 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695121#comment-14695121 ] Hudson commented on HADOOP-12295: --------------------------------- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/]) HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev 53bef9c5b98dee87d4ffaf35415bc38e2f876ed8) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * hadoop-common-project/hadoop-common/CHANGES.txt > Improve NetworkTopology#InnerNode#remove logic > ---------------------------------------------- > > Key: HADOOP-12295 > URL: https://issues.apache.org/jira/browse/HADOOP-12295 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: 2.8.0 > > Attachments: HADOOP-12295.001.patch > > > In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get the parent node, no need to loop the {{children}} list. Then it is more efficient since in most cases deleting parent node doesn't happen. > Another nit in current code is: > {code} > String parent = n.getNetworkLocation(); > String currentPath = getPath(this); > {code} > can be in closure of {{\!isAncestor\(n\)}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)