hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12336) github_jira_bridge doesn't work
Date Sun, 30 Aug 2015 14:37:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721534#comment-14721534
] 

Kengo Seki commented on HADOOP-12336:
-------------------------------------

I tried 00.patch on HADOOP-11820 and confirmed the PR is successfully applied. But some nits:

{code}
  urlfromjira=$(${AWK} 'match($0,"https://github.com/.*patch"){print substr($0,RSTART,RLENGTH)}'
"${PATCH_DIR}/jira" | tail -1)
{code}

* Using $\{GITHUB_BASE_URL} instead of a hard-coded URL seems better. Is there any reason?
* "https://github.com/[^ ]*patch" seems safer, as well as jira_locate_patch does.


> github_jira_bridge doesn't work
> -------------------------------
>
>                 Key: HADOOP-12336
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12336
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: HADOOP-12336.HADOOP-12111.00.patch
>
>
> The github_jira_bridge (which allows the JIRA bugsystem to switch to github mode) is
failing. See comments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message