hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12324) Better exception reporting in SaslPlainServer
Date Tue, 18 Aug 2015 13:36:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701256#comment-14701256
] 

Sean Busbey commented on HADOOP-12324:
--------------------------------------

total side effects of this change, AFAICT:

* Addition of class name for underlying cause in  all cases
* localized message is used instead of the raw message

The example failures above are from the first change. I'd be very surprised if we have any
tests that cover the second one.

> Better exception reporting in SaslPlainServer
> ---------------------------------------------
>
>                 Key: HADOOP-12324
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12324
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.8.0
>            Reporter: Mike Yoder
>            Assignee: Mike Yoder
>            Priority: Minor
>         Attachments: HADOOP-12324.000.patch
>
>
> This is a follow up from HADOOP-12318.  The review comment from [~stevel@apache.org]:
> {quote}
> -1. It's critical to use Exception.toString() and not .getMessage(), as some exceptions
(NPE) don't have messages.
> {quote}
> This is the promised follow-up Jira.
> CC: [~atm]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message