hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12324) Better exception reporting in SaslPlainServer
Date Tue, 18 Aug 2015 13:33:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701251#comment-14701251
] 

Sean Busbey commented on HADOOP-12324:
--------------------------------------

example of related failed test:

{code}
Tests run: 85, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 27.003 sec <<< FAILURE!
- in org.apache.hadoop.ipc.TestSaslRPC
testSaslPlainServerBadPassword[0](org.apache.hadoop.ipc.TestSaslRPC)  Time elapsed: 0.029
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<PLAIN auth failed: []wrong password> but was:<PLAIN
auth failed: [java.lang.IllegalArgumentException: ]wrong password>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.ipc.TestSaslRPC.testSaslPlainServerBadPassword(TestSaslRPC.java:561)

testSaslPlainServerBadPassword[1](org.apache.hadoop.ipc.TestSaslRPC)  Time elapsed: 0.011
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<PLAIN auth failed: []wrong password> but was:<PLAIN
auth failed: [java.lang.IllegalArgumentException: ]wrong password>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.ipc.TestSaslRPC.testSaslPlainServerBadPassword(TestSaslRPC.java:561)

testSaslPlainServerBadPassword[2](org.apache.hadoop.ipc.TestSaslRPC)  Time elapsed: 0.005
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<PLAIN auth failed: []wrong password> but was:<PLAIN
auth failed: [java.lang.IllegalArgumentException: ]wrong password>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.ipc.TestSaslRPC.testSaslPlainServerBadPassword(TestSaslRPC.java:561)

testSaslPlainServerBadPassword[3](org.apache.hadoop.ipc.TestSaslRPC)  Time elapsed: 0.007
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<PLAIN auth failed: []wrong password> but was:<PLAIN
auth failed: [java.lang.IllegalArgumentException: ]wrong password>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.ipc.TestSaslRPC.testSaslPlainServerBadPassword(TestSaslRPC.java:561)

testSaslPlainServerBadPassword[4](org.apache.hadoop.ipc.TestSaslRPC)  Time elapsed: 0.006
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<PLAIN auth failed: []wrong password> but was:<PLAIN
auth failed: [java.lang.IllegalArgumentException: ]wrong password>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.ipc.TestSaslRPC.testSaslPlainServerBadPassword(TestSaslRPC.java:561)

{code}

> Better exception reporting in SaslPlainServer
> ---------------------------------------------
>
>                 Key: HADOOP-12324
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12324
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.8.0
>            Reporter: Mike Yoder
>            Assignee: Mike Yoder
>            Priority: Minor
>         Attachments: HADOOP-12324.000.patch
>
>
> This is a follow up from HADOOP-12318.  The review comment from [~stevel@apache.org]:
> {quote}
> -1. It's critical to use Exception.toString() and not .getMessage(), as some exceptions
(NPE) don't have messages.
> {quote}
> This is the promised follow-up Jira.
> CC: [~atm]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message