hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12316) Potential false-positive and false-negative in parsing TAP output
Date Thu, 13 Aug 2015 20:36:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Allen Wittenauer updated HADOOP-12316:
       Resolution: Fixed
    Fix Version/s: HADOOP-12111
           Status: Resolved  (was: Patch Available)

> Potential false-positive and false-negative in parsing TAP output
> -----------------------------------------------------------------
>                 Key: HADOOP-12316
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12316
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>             Fix For: HADOOP-12111
>         Attachments: HADOOP-12316.HADOOP-12111.00.patch
> In tap.sh, TAP results are parsed as follows:
> {code}
>   filenames=$(find "${TAP_LOG_DIR}" -type f -exec "${GREP}" -l -E "not ok " {} \;)
> {code}
> But this regex seems to have the following problems:
> 1. According to [the TAP specification|https://testanything.org/tap-specification.html],
"ok" / "not ok" is only required in the test line and others are optional. So each line can
be terminated with just "ok" or "not ok", without trailing spaces. In that case, the regex
"not ok " will miss test failures.
> 2. TAP output can contain descriptions and diagnostics. If they contains the string "not
ok ", a false-alarm will be raised.
> They won't occur as far as we are using only bats, but considering supporting other test
tools in the future, the regex should be replaced with "^not ok".

This message was sent by Atlassian JIRA

View raw message