hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
Date Mon, 03 Aug 2015 12:58:05 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yi Liu updated HADOOP-12295:
----------------------------
    Attachment: HADOOP-12295.001.patch

> Improve NetworkTopology#InnerNode#remove logic
> ----------------------------------------------
>
>                 Key: HADOOP-12295
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12295
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get the parent
node, no need to loop the {{children}} list.
> Another nit in current code is:
> {code}
>   String parent = n.getNetworkLocation();
>   String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message