hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12287) add support for perl
Date Sat, 01 Aug 2015 21:08:04 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kengo Seki updated HADOOP-12287:
--------------------------------
    Attachment: HADOOP-12287.HADOOP-12111.00.patch

Perl::Lint is faster, but it seems not enough matured (e.g., no command line tool, no configuration
file, no output formatter, etc.).  As a starting point, it seems better to use Perl::Critic,
though we might replace it in the future.

Attaching a wip patch. It does not contain Dockerfile modification, because I'm in narrow-band
environment now and Docker doesn't work well. I'll submit later.

Test result is as follows:

{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch 
diff --git a/test/e2e/pig/streaming/PigStreaming.pl b/test/e2e/pig/streaming/PigStreaming.pl
index 26a4a3b..cdbb0ef 100644
--- a/test/e2e/pig/streaming/PigStreaming.pl
+++ b/test/e2e/pig/streaming/PigStreaming.pl
@@ -17,7 +17,6 @@
 #  limitations under the License.                                                      
                                                                                        
 
-use strict;
 
 # This script is used to test streaming in pig.
 # Usage: PigStreaming.pl <input> <output> <support file>
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=/Users/sekikn/pig --project=pig
/tmp/test.patch 

(snip)

| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  +1  |       @author  |  0m 00s    | The patch does not contain any @author 
|      |                |            | tags.
|  +1  |    asflicense  |  0m 36s    | Patch does not generate ASF License 
|      |                |            | warnings.
|  -1  |    perlcritic  |  0m 05s    | The applied patch generated 1 new 
|      |                |            | Perl::Critic issues (total was 50, now
|      |                |            | 51).
|  +1  |    whitespace  |  0m 00s    | Patch has no whitespace issues. 
|      |                |  0m 42s    | 


|| Subsystem || Report/Notes ||
============================================================================
| git revision | trunk / 88ed5c9 |
| Optional Tests | asflicense perlcritic |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28 11:35:04 PDT
2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | ant |
| Personality | /Users/sekikn/hadoop/dev-support/personality/pig.sh |
| Default Java | 1.7.0_80 |
| perlcritic | v1.125 |
| perlcritic | /private/tmp/test-patch-pig/3513/diff-patch-perlcritic.txt |


============================================================================
============================================================================
                              Finished build.
============================================================================
============================================================================


[sekikn@mobile hadoop]$ cat /private/tmp/test-patch-pig/3513/diff-patch-perlcritic.txt
test/e2e/pig/streaming/PigStreaming.pl:28:1:Code before strictures are enabled
{code}

> add support for perl
> --------------------
>
>                 Key: HADOOP-12287
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12287
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>         Attachments: HADOOP-12287.HADOOP-12111.00.patch
>
>
> To increase our language coverage, we should add Perl::Critic support or maybe use Perl::Lint.
 It might be faster to use -Mstrict -Mdiagnostics -cw to at least get something basic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message