hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12129) rework test-patch bug system support
Date Sat, 15 Aug 2015 05:48:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698127#comment-14698127
] 

Sean Busbey commented on HADOOP-12129:
--------------------------------------

{code}
+  while read -r line; do
+    {
+      printf "%s" $(echo "${line}" | cut -f1-2 -d:)
+      echo "${comment}"
+    } >> "${tmpfile}"
{code}

As of shellcheck 3.3.7 that precommit flag still shows up:

{noformat}
In dev-support/test-patch.d/whitespace.sh line 29:
      printf "%s" $(echo "${line}" | cut -f1-2 -d:)
                  ^-- SC2046: Quote this to prevent word splitting.

{noformat}

> rework test-patch bug system support
> ------------------------------------
>
>                 Key: HADOOP-12129
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12129
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: HADOOP-12129.HADOOP-12111.00.patch, HADOOP-12129.HADOOP-12111.01.patch,
HADOOP-12129.HADOOP-12111.02.patch, HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch
>
>
> WARNING: this is a fairly big project.
> See first comment for a brain dump on the issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message