hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10949) Write metrics2 sink plugin for Apache Kafka -- KafkaSink
Date Thu, 20 Aug 2015 21:00:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705741#comment-14705741
] 

Ravi Prakash commented on HADOOP-10949:
---------------------------------------

1. You're sending the same message to multiple topics? Why? Do you have a usecase in mind?
I thought constraining to 1 topic was perfectly acceptable.
2. {{producer = null;}} should be in a finally block in close() 
3. Please follow 2-space indentation.
4. Rather than multiple calls to {{cal}}, you should use DateFormat.
5. I am still not sure about the synchronous send. https://cwiki.apache.org/confluence/display/KAFKA/0.8.0+Producer+Example
says
bq. ** PLEASE NOTE ** The recommended producer is from latest stable release using the new
Java producer http://kafka.apache.org/082/javadoc/org/apache/kafka/clients/producer/KafkaProducer.html

> Write metrics2 sink plugin for Apache Kafka -- KafkaSink
> --------------------------------------------------------
>
>                 Key: HADOOP-10949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10949
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: metrics
>            Reporter: Babak Behzad
>            Assignee: Babak Behzad
>         Attachments: HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch,
HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch, HADOOP-10949.patch,
HADOOP-10949.patch, HADOOP-10949.patch
>
>
> Write a metrics2 sink plugin for Hadoop to send metrics directly to Apache Kafka in addition
to the current, Graphite ([Hadoop-9704|https://issues.apache.org/jira/browse/HADOOP-9704]),
Ganglia and File sinks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message