hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kiran Kumar M R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10365) BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
Date Wed, 12 Aug 2015 12:40:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693418#comment-14693418
] 

Kiran Kumar M R commented on HADOOP-10365:
------------------------------------------

[~ozawa] I have attached a patch after removing {{outputStream.close();}} please review

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Assignee: Kiran Kumar M R
>            Priority: Minor
>              Labels: BB2015-05-RFC
>         Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch, HADOOP-10365.4.patch,
HADOOP-10365.5.patch, HADOOP-10365.6.patch, HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message