Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F210418A6C for ; Fri, 10 Jul 2015 04:11:09 +0000 (UTC) Received: (qmail 41107 invoked by uid 500); 10 Jul 2015 04:11:04 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41056 invoked by uid 500); 10 Jul 2015 04:11:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41045 invoked by uid 99); 10 Jul 2015 04:11:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2015 04:11:04 +0000 Date: Fri, 10 Jul 2015 04:11:04 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12196) shellcheck plugin is picking up target executables MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621690#comment-14621690 ] Hadoop QA commented on HADOOP-12196: ------------------------------------ (!) A patch to the files used for the QA process has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/7224/console in case of problems. > shellcheck plugin is picking up target executables > -------------------------------------------------- > > Key: HADOOP-12196 > URL: https://issues.apache.org/jira/browse/HADOOP-12196 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Reporter: Allen Wittenauer > Assignee: Kengo Seki > Attachments: HADOOP-12196.HADOOP-12111.01.patch > > > When hadoop-yarn-server-nodemanager is in the build, it generates target/native/target/usr/local/bin/(test-)container-executor. shellcheck picks these up and throws a "hGetContents: invalid argument (invalid byte sequence)" error. > We need some sort of safety to determine if a file is binary or shell code and/or prevent target directories from getting picked up. I suspect the former to be more reliable than the latter since we can't assume maven. -- This message was sent by Atlassian JIRA (v6.3.4#6332)