Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 22 Jul 2015 01:38:04 +0000 (UTC)
From: "Kengo Seki (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12841059.1435389441000.250434.1437529084965@Atlassian.JIRA>
In-Reply-To: <JIRA.12841059.1435389441000@Atlassian.JIRA>
References: <JIRA.12841059.1435389441000@Atlassian.JIRA>
 <JIRA.12841059.1435389441259@arcas>
Subject: [jira] [Commented] (HADOOP-12130) document features added in 12113
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636110#comment-14636110 ] 

Kengo Seki commented on HADOOP-12130:
-------------------------------------

+1 non-binding other than following minor nits.

h4. precommit-advanced.md:

{code}
* pluginname_preapply
    - executed prior to the patch being applied.  This is useful for any "before"-type data collection for later comparisons
{code}

needs a period

{code}
## Test Determination

The `personality_file_tests` function determines which tests to turn on based upon the file name.  It is realtively simple.  For example, to turn on a full suite of tests for Java files:
{code}

s/realtively/relatively/

h4. precommit-basic.md

{code}
* shellcheck installed, preferably 0.3.6 and higher
{code}

s/and higher/or higher/

{code}
After the tests have run, there is a directory that contains all of the test-patch related artifacts.  This is generally referred to as the patchprocess directory.  By default, test-patch tries to make something off of /tmp to contain this content.  Using the `--patchdir` option, one can specify exactly which directory to use.
{code}

s/\-\-patchdir/--patch-dir/

{code}
```bash
$ test-patch.sh (other options) --built-tool=ant
```
{code}

s/built-tool/build-tool/

{code}
# MultiJDK

For many projects, it is useful to test Java code against multiple versions of JDKs at the same time.  test-patch can do this with the -multijdkdirs option:
{code}

s/\-multijdkdirs/--multijdkdirs/

> document features added in 12113
> --------------------------------
>
>                 Key: HADOOP-12130
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12130
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-12130.HADOOP-12111.00.patch, HADOOP-12130.HADOOP-12111.01.patch
>
>
> We need to write up more documentation, especially around the new stuff added in 12113, since a lot of people are looking for information on those bits.  (e.g., "How do I use multiJDK mode?")


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)