Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF21C1811E for ; Tue, 7 Jul 2015 21:15:06 +0000 (UTC) Received: (qmail 33931 invoked by uid 500); 7 Jul 2015 21:15:06 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 33888 invoked by uid 500); 7 Jul 2015 21:15:06 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 33871 invoked by uid 99); 7 Jul 2015 21:15:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 21:15:06 +0000 Date: Tue, 7 Jul 2015 21:15:06 +0000 (UTC) From: "Andrew Wang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11903) test-patch should fail any new classes called Default-foo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617432#comment-14617432 ] Andrew Wang commented on HADOOP-11903: -------------------------------------- Well, I knew it was parsing args, but didn't know what "#*=" meant. Not easy to search for. > test-patch should fail any new classes called Default-foo > --------------------------------------------------------- > > Key: HADOOP-11903 > URL: https://issues.apache.org/jira/browse/HADOOP-11903 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Affects Versions: HADOOP-12111 > Reporter: Allen Wittenauer > Assignee: Kengo Seki > Attachments: HADOOP-11903.HADOOP-12111.00.patch > > > In the past, we've named things like DefaultResourceCalculator, DefaultContainerExecutor, and DefaultCodec that do nothing but cause problems down the road since they are effectively version and functionality locked forever. If these examples had been named what they truly were (e.g., MemoryResourceCalculator, SimpleContainerExecutor, and GZipCodec), the defaults could then be changed in the future in a compatible way. > One way to enforce this is to prevent the creation of new classes called Default-anything. -- This message was sent by Atlassian JIRA (v6.3.4#6332)