Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC46F186B5 for ; Wed, 15 Jul 2015 05:26:05 +0000 (UTC) Received: (qmail 7308 invoked by uid 500); 15 Jul 2015 05:26:05 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 7262 invoked by uid 500); 15 Jul 2015 05:26:05 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 7250 invoked by uid 99); 15 Jul 2015 05:26:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 05:26:05 +0000 Date: Wed, 15 Jul 2015 05:26:05 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11398) RetryUpToMaximumTimeWithFixedSleep needs to behave more accurately MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627548#comment-14627548 ] Akira AJISAKA commented on HADOOP-11398: ---------------------------------------- bq. I think your 003 patch changes retry policy from stateless to stateful again. Am I missing anything here? Yes, the patch makes the policy stateful, however, it becomes thread-safe by synchronizing shouldRetry method. > RetryUpToMaximumTimeWithFixedSleep needs to behave more accurately > ------------------------------------------------------------------ > > Key: HADOOP-11398 > URL: https://issues.apache.org/jira/browse/HADOOP-11398 > Project: Hadoop Common > Issue Type: Bug > Reporter: Li Lu > Assignee: Li Lu > Attachments: HADOOP-11398-121114.patch, HADOOP-11398.002.patch, HADOOP-11398.003.patch > > > RetryUpToMaximumTimeWithFixedSleep now inherits RetryUpToMaximumCountWithFixedSleep and just acts as a wrapper to decide maxRetries. The current implementation uses (maxTime / sleepTime) as the number of maxRetries. This is fine if the actual for each retry is significantly less than the sleep time, but it becomes less accurate if each retry takes comparable amount of time as the sleep time. The problem gets worse when there are underlying retries. > We may want to use timers inside RetryUpToMaximumTimeWithFixedSleep to perform accurate timing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)