hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-12272) Refactor ipc.Server and implementations to reduce constructor bloat
Date Fri, 24 Jul 2015 23:19:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641222#comment-14641222
] 

Arpit Agarwal edited comment on HADOOP-12272 at 7/24/15 11:18 PM:
------------------------------------------------------------------

Ran into this while adding a new Server constructor parameter for HADOOP-12250. Will work
on the refactoring after fixing HADOOP-12250 so leaving unassigned for now.

I have an incomplete patch to refactor the ipc code but need to fix usages in the rest of
the code.


was (Author: arpitagarwal):
Ran into this while adding a new Server constructor parameter for HADOOP-12250. Will probably
perform the refactoring after fixing HADOOP-12250.

I have an incomplete patch to refactor the ipc code but need to fix usages in the rest of
the code.

> Refactor ipc.Server and implementations to reduce constructor bloat
> -------------------------------------------------------------------
>
>                 Key: HADOOP-12272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12272
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>            Reporter: Arpit Agarwal
>
> {{ipc.Server}} and its implementations have constructors taking large number of parameters.
This code can be simplified quite a bit by just moving RPC.Builder to the Server class and
passing the builder object to constructors.
> The refactoring should be safe based on the class annotations but need to confirm no
dependent components will break.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message