hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12256) add support for ruby-lint
Date Fri, 31 Jul 2015 15:30:06 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kengo Seki updated HADOOP-12256:
--------------------------------
    Attachment: HADOOP-12256.HADOOP-12111.01.patch

-01:

* sort the ruby-lint output, because its order seems to change trial-to-trial
* fixed correct Docker file

Sample result:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch 
diff --git a/bin/draining_servers.rb b/bin/draining_servers.rb
index 45c9694..d29b718 100644
--- a/bin/draining_servers.rb
+++ b/bin/draining_servers.rb
@@ -15,6 +15,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+foo
 
 # Add or remove servers from draining mode via zookeeper 
 
@@ -162,3 +163,4 @@ case ARGV[0]
     puts optparse
     exit 3
 end
+bar
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=/Users/sekikn/hbase --project=hbase
/tmp/test.patch 

(snip)

| Vote |       Subsystem |  Runtime   | Comment
============================================================================
|  +1  |        @author  |  0m 00s    | The patch does not contain any @author 
|      |                 |            | tags.
|  +1  |     asflicense  |  0m 20s    | Patch does not generate ASF License 
|      |                 |            | warnings.
|  +1  |        rubocop  |  0m 03s    | There were no new rubocop issues. 
|  -1  |      ruby-lint  |  0m 01s    | The applied patch generated 2 new 
|      |                 |            | ruby-lint issues (total was 34, now 36).
|  +1  |     whitespace  |  0m 00s    | Patch has no whitespace issues. 
|  +1  |    hadoopcheck  |  8m 33s    | Patch does not cause any errors with 
|      |                 |            | Hadoop 2.4.1 2.5.2 2.6.0.
|      |                 |  8m 59s    | 


|| Subsystem || Report/Notes ||
============================================================================
| git revision | master / f1f0d99 |
| Optional Tests | asflicense rubocop ruby_lint |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28 11:35:04 PDT
2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/hadoop/dev-support/personality/hbase.sh |
| Default Java | 1.7.0_80 |
| rubocop | v0.32.1 |
| ruby-lint | v2.0.4 |
| ruby-lint | /private/tmp/test-patch-hbase/9098/diff-patch-ruby-lint.txt |
| Max memory used | 148MB |


============================================================================
============================================================================
                              Finished build.
============================================================================
============================================================================


[sekikn@mobile hadoop]$ cat /private/tmp/test-patch-hbase/9098/diff-patch-ruby-lint.txt
/Users/sekikn/hbase/bin/draining_servers.rb:E:18:1: undefined method foo
/Users/sekikn/hbase/bin/draining_servers.rb:E:166:1: undefined method bar
{code}

> add support for ruby-lint
> -------------------------
>
>                 Key: HADOOP-12256
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12256
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>         Attachments: HADOOP-12256.HADOOP-12111.00.patch, HADOOP-12256.HADOOP-12111.01.patch
>
>
> We should add support for ruby-lint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message