hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12255) Add support for rubocop
Date Thu, 30 Jul 2015 15:41:05 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kengo Seki updated HADOOP-12255:
--------------------------------
    Attachment: HADOOP-12255.HADOOP-12111.00.patch

Attaching a patch, which needs HADOOP-12266 committed.

Result against HBase (mvn executions skipped by Ctrl-C):

{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch 
diff --git a/hbase-shell/src/main/ruby/hbase.rb b/hbase-shell/src/main/ruby/hbase.rb
index aca1006..a4303dc 100644
--- a/hbase-shell/src/main/ruby/hbase.rb
+++ b/hbase-shell/src/main/ruby/hbase.rb
@@ -53,7 +53,7 @@ module HBaseConstants
   METRICS = "METRICS"
   REVERSED = "REVERSED"
   REPLICATION_SCOPE = "REPLICATION_SCOPE"
-  INTERVAL = 'INTERVAL'
+  INTERVAL = "INTERVAL"
   CACHE = 'CACHE'
   FILTER = 'FILTER'
   SPLITS = 'SPLITS'
@@ -78,7 +78,7 @@ module HBaseConstants
   CLUSTER_KEY = 'CLUSTER_KEY'
   TABLE_CFS = 'TABLE_CFS'
   CONFIG = 'CONFIG'
-  DATA = 'DATA'
+  DATA = "DATA"
 
   # Load constants from hbase java API
   def self.promote_constants(constants)
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=/Users/sekikn/hbase --project=hbase
/tmp/test.patch 

(snip)

| Vote |       Subsystem |  Runtime   | Comment
============================================================================
|  -1  |     mvninstall  |  0m 06s    | root in master failed. 
|  -1  |          javac  |  0m 04s    | root in master failed. 
|  -1  |        javadoc  |  0m 04s    | hbase-shell in master failed. 
|  +1  |        @author  |  0m 00s    | The patch does not contain any @author 
|      |                 |            | tags.
|  -1  |     test4tests  |  0m 00s    | The patch doesn't appear to include any 
|      |                 |            | new or modified tests. Please justify
|      |                 |            | why no new tests are needed for this
|      |                 |            | patch. Also please list what manual
|      |                 |            | steps were performed to verify this
|      |                 |            | patch.
|  -1  |          javac  |  0m 05s    | root in the patch failed. 
|  -1  |     asflicense  |  0m 04s    | root in the patch failed. 
|  -1  |        rubocop  |  0m 03s    | The applied patch generated 2 new 
|      |                 |            | rubocop issues (total was 34, now 36).
|  +1  |     whitespace  |  0m 00s    | Patch has no whitespace issues. 
|  +1  |    hadoopcheck  |  0m 12s    | Patch does not cause any errors with 
|      |                 |            | Hadoop 2.4.1 2.5.2 2.6.0.
|  +1  |     mvninstall  |  0m 00s    | the patch passed 
|  -1  |        javadoc  |  0m 04s    | hbase-shell in the patch failed. 
|  -1  |        eclipse  |  0m 03s    | hbase-shell in the patch failed. 
|      |                 |  0m 45s    | 


|| Subsystem || Report/Notes ||
============================================================================
| git revision | master / 5f1129c |
| Optional Tests | asflicense javac javadoc mvninstall unit rubocop |
| uname | Darwin mobile.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28 11:35:04 PDT
2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/hadoop/dev-support/personality/hbase.sh |
| Default Java | 1.7.0_80 |
| mvninstall | /private/tmp/test-patch-hbase/2711/branch-mvninstall-root.txt |
| javac | /private/tmp/test-patch-hbase/2711/branch-javac-root.txt |
| javadoc | /private/tmp/test-patch-hbase/2711/branch-javadoc-hbase-shell.txt |
| javac | /private/tmp/test-patch-hbase/2711/patch-javac-root.txt |
| asflicense | /private/tmp/test-patch-hbase/2711/patch-asflicense-root.txt |
| rubocop | v0.32.1 |
| rubocop | /private/tmp/test-patch-hbase/2711/diff-patch-rubocop.txt |
| javadoc | /private/tmp/test-patch-hbase/2711/patch-javadoc-hbase-shell.txt |
| eclipse | /private/tmp/test-patch-hbase/2711/patch-eclipse-hbase-shell.txt |


============================================================================
============================================================================
                              Finished build.
============================================================================
============================================================================


[sekikn@mobile hadoop]$ cat /private/tmp/test-patch-hbase/2711/diff-patch-rubocop.txt
hbase-shell/src/main/ruby/hbase.rb:56:14: C: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
  INTERVAL = "INTERVAL"
             ^^^^^^^^^^
hbase-shell/src/main/ruby/hbase.rb:81:10: C: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
  DATA = "DATA"
         ^^^^^^
{code}

> Add support for rubocop
> -----------------------
>
>                 Key: HADOOP-12255
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12255
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>         Attachments: HADOOP-12255.HADOOP-12111.00.patch
>
>
> We should support rubocop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message