hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12254) test-patch.sh should run findbugs if ony findbugs-exclude.xml has changed
Date Mon, 27 Jul 2015 16:52:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643011#comment-14643011
] 

Kengo Seki commented on HADOOP-12254:
-------------------------------------

Surprisingly, the filefilter function in the findbugs plugin has a wrong name. It's never
called.

{code}
function findbugs_file_filter
{
  local filename=$1

  if [[ ${BUILDTOOL} == maven
    || ${BUILDTOOL} == ant ]]; then
    if [[ ${filename} =~ \.java$ ]]; then
      add_test findbugs
    fi
  fi
}
{code}

> test-patch.sh should run findbugs if ony findbugs-exclude.xml has changed
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-12254
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12254
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Varun Saxena
>
> Refer to Hadoop QA report for YARN-3952
> https://issues.apache.org/jira/browse/YARN-3952?focusedCommentId=14636455&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636455
> We can run findbugs for all the submodules if findbugs-exclude.xml has been changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message