hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12226) CHANGED_MODULES is wrong for ant
Date Thu, 16 Jul 2015 17:12:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630018#comment-14630018
] 

Sean Busbey commented on HADOOP-12226:
--------------------------------------

{code}
+  if [[ ${count} -lt 2 ]]; then
+    yetus_debug "Only one entry, so keeping it ${CHANGED_MODULES}"
+    CHANGED_UNION_MODULES=${CHANGED_MODULES}
+    return
+  fi
{code}

missed a {{# shellcheck disable=SC2034}}, fine with fix on commit.

otherwise +1 LGTM.

> CHANGED_MODULES is wrong for ant
> --------------------------------
>
>                 Key: HADOOP-12226
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12226
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-12226.HADOOP-12111.00.patch
>
>
> CHANGED_MODULES assumes maven and will have incorrect results for ant.
> We may need to rethink how this and CHANGED_UNFILTERED_MODULES work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message