hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12194) Support for incremental generation in the protoc plugin
Date Tue, 07 Jul 2015 19:35:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617236#comment-14617236
] 

Hadoop QA commented on HADOOP-12194:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 28s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 36s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 42s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 16s | The applied patch generated  1 new checkstyle
issues (total was 2, now 3). |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 13s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   0m 39s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | maven tests |   0m 13s | Tests passed in hadoop-maven-plugins.
|
| | |  36m  9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12744015/hadoop-12194.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 3dc92e8 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HADOOP-Build/7179/artifact/patchprocess/diffcheckstylehadoop-maven-plugins.txt
|
| hadoop-maven-plugins test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7179/artifact/patchprocess/testrun_hadoop-maven-plugins.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7179/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7179/console |


This message was automatically generated.

> Support for incremental generation in the protoc plugin
> -------------------------------------------------------
>
>                 Key: HADOOP-12194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12194
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.6-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-12194.001.patch, hadoop-12194.002.patch
>
>
> The protoc maven plugin currently generates new Java classes every time, which means
Maven always picks up changed files in the build. It would be better if the protoc plugin
only generated new Java classes when the source protoc files change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message