hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12183) Add annotation to tracing span of FsShell to record args
Date Thu, 30 Jul 2015 19:16:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648147#comment-14648147

Colin Patrick McCabe commented on HADOOP-12183:

Looks good!  Can we add a sanity check that the string is not too long.  For example, {{scope.getSpan().addKVAnnotation("args",
StringUtils.join(" ", argv).substring(0, 2048)}}.  That way if some bizarrely long command
line comes along, we won't create a huge trace span.

> Add annotation to tracing span of FsShell to record args
> --------------------------------------------------------
>                 Key: HADOOP-12183
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12183
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tracing
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: HADOOP-12183.001.patch
> Tracing span of FsShell contains only command name as its description. Adding whole command
line arguments as KV annotation to span helps analyze traces later.

This message was sent by Atlassian JIRA

View raw message