hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12176) smart-apply-patch.sh fails to identify git patch prefixes in some cases
Date Fri, 03 Jul 2015 06:37:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612897#comment-14612897
] 

Vinayakumar B commented on HADOOP-12176:
----------------------------------------

Re-write looks better. Do we have chance to port it back to trunk before Yetus is completed?
or till then this patch can go in?
Because I am kind of blocked here, as latest patch on HDFS-7285 is not applying because of
the above mentioned issue.


> smart-apply-patch.sh fails to identify git patch prefixes in some cases
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-12176
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12176
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HADOOP-12176-01.patch
>
>
> after HADOOP-12018, git apply supported with --no-prefix.
> But for some patches this detection will identify git patch with prefix as no-prefix
patch and fails to apply.
> Example case is ; If patch contains a line changed with '+++' or '---' somewhere in between.
May be a javadoc update. This makes detection wrong and git apply will fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message