hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12165) author tests show entire run time not test time when skipped
Date Thu, 09 Jul 2015 23:40:04 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kengo Seki updated HADOOP-12165:
--------------------------------
    Attachment: HADOOP-12165.HADOOP-12111.01.patch

Attaching a patch. Before applying this patch (I cancelled mvn running by Ctrl-C):

{code}
| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  -1  |    mvninstall  |  0m 07s    | root in trunk failed. 
|  -1  |         javac  |  0m 06s    | hadoop-common in trunk failed. 
|  -1  |       javadoc  |  0m 06s    | hadoop-common in trunk failed. 
|   0  |       @author  |  0m 19s    | Skipping @author checks as test-patch.sh 
|      |                |            | has been patched.
{code}

And after:

{code}
| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  -1  |    mvninstall  |  0m 09s    | root in trunk failed. 
|  -1  |         javac  |  0m 06s    | hadoop-common in trunk failed. 
|  -1  |       javadoc  |  0m 06s    | hadoop-common in trunk failed. 
|   0  |       @author  |  0m 00s    | Skipping @author checks as test-patch.sh 
|      |                |            | has been patched.
{code}

But I can't understand yet why we should skip @author checks if test-patch.sh is modified.

> author tests show entire run time not test time when skipped
> ------------------------------------------------------------
>
>                 Key: HADOOP-12165
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12165
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>            Reporter: Allen Wittenauer
>            Priority: Trivial
>         Attachments: HADOOP-12165.HADOOP-12111.01.patch
>
>
> if test-patch skips the @author check, the vote table has the global timer and not the
local timer, likely due to a missing start_clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message