hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11903) test-patch plugin for checking file name conventions
Date Wed, 08 Jul 2015 16:11:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618840#comment-14618840
] 

Hadoop QA commented on HADOOP-11903:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 5s {color}
| {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 26s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12744241/HADOOP-11903.HADOOP-12111.02.patch
|
| git revision | HADOOP-12111 / 8243608 |
| Optional Tests | asflicense shellcheck |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/dev-support-test/personality/hadoop.sh
|
| Default Java | 1.7.0_55 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 /home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55
|
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.)
|
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7197/console |


This message was automatically generated.

> test-patch plugin for checking file name conventions
> ----------------------------------------------------
>
>                 Key: HADOOP-11903
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11903
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>         Attachments: HADOOP-11903.HADOOP-12111.00.patch, HADOOP-11903.HADOOP-12111.01.patch,
HADOOP-11903.HADOOP-12111.02.patch
>
>
> Providing yetus with the functionality to detect newly added files which doesn't follow
the naming conventions. As for java, it also can be used for checking classnames. In the past,
we've named things like DefaultResourceCalculator, DefaultContainerExecutor, and DefaultCodec
that do nothing but cause problems down the road since they are effectively version and functionality
locked forever.  If these examples had been named what they truly were (e.g., MemoryResourceCalculator,
SimpleContainerExecutor, and GZipCodec), the defaults could then be changed in the future
in a compatible way. One way to enforce this is to prevent the creation of new classes called
Default-anything. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message