hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11903) test-patch should fail any new classes called Default-foo
Date Tue, 07 Jul 2015 02:37:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616083#comment-14616083
] 

Andrew Wang commented on HADOOP-11903:
--------------------------------------

I mean, that only happens if someone explicitly adds the gitignored file. It doesn't happen
automatically on add -A or add -u. Git prompts when you manually add it too:

{noformat}
-> % git add blah.rej
The following paths are ignored by one of your .gitignore files:
blah.rej
Use -f if you really want to add them.
{noformat}

So it's possible to get around the gitignore if you really want, but the probability seems
very small.

If you really wanted to address this, you'd also need the same excludes both in .gitignore
and in Yetus config, which seems like a lot of extra synchronization for something that doesn't
really happen in practice.

> test-patch should fail any new classes called Default-foo
> ---------------------------------------------------------
>
>                 Key: HADOOP-11903
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11903
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>         Attachments: HADOOP-11903.HADOOP-12111.00.patch
>
>
> In the past, we've named things like DefaultResourceCalculator, DefaultContainerExecutor,
and DefaultCodec that do nothing but cause problems down the road since they are effectively
version and functionality locked forever.  If these examples had been named what they truly
were (e.g., MemoryResourceCalculator, SimpleContainerExecutor, and GZipCodec), the defaults
could then be changed in the future in a compatible way. 
> One way to enforce this is to prevent the creation of new classes called Default-anything.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message