hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11398) RetryUpToMaximumTimeWithFixedSleep needs to behave more accurately
Date Wed, 15 Jul 2015 05:26:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627548#comment-14627548
] 

Akira AJISAKA commented on HADOOP-11398:
----------------------------------------

bq. I think your 003 patch changes retry policy from stateless to stateful again. Am I missing
anything here?
Yes, the patch makes the policy stateful, however, it becomes thread-safe by synchronizing
shouldRetry method.

> RetryUpToMaximumTimeWithFixedSleep needs to behave more accurately
> ------------------------------------------------------------------
>
>                 Key: HADOOP-11398
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11398
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: HADOOP-11398-121114.patch, HADOOP-11398.002.patch, HADOOP-11398.003.patch
>
>
> RetryUpToMaximumTimeWithFixedSleep now inherits RetryUpToMaximumCountWithFixedSleep and
just acts as a wrapper to decide maxRetries. The current implementation uses (maxTime / sleepTime)
as the number of maxRetries. This is fine if the actual for each retry is significantly less
than the sleep time, but it becomes less accurate if each retry takes comparable amount of
time as the sleep time. The problem gets worse when there are underlying retries. 
> We may want to use timers inside RetryUpToMaximumTimeWithFixedSleep to perform accurate
timing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message