hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Walsh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere
Date Fri, 31 Jul 2015 14:34:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649289#comment-14649289
] 

Martin Walsh commented on HADOOP-7824:
--------------------------------------

Addressed the nits as recommended.  Just re-spinning locally to make sure all looks good.

I changed ReadaheadPool.java and a number of other files to allow us to utilise the static
import, as mentioned in the comments above. e.g. in ReadaheadPool.java:

-            fd, off, len, NativeIO.POSIX.POSIX_FADV_WILLNEED);
+            fd, off, len, POSIX_FADV_WILLNEED);

> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Martin Walsh
>              Labels: hadoop
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-7824.001.patch, HADOOP-7824.002.patch, HADOOP-7824.003.patch,
HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating
systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message