hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Walsh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere
Date Wed, 22 Jul 2015 09:38:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636594#comment-14636594
] 

Martin Walsh commented on HADOOP-7824:
--------------------------------------

Thanks for the comments [~cmccabe].  I added the new structures to make it simple to maintain
the list of constants being initialised as they would all be in the list at the top of the
file.  I would argue that modifying that list of consts at the top of the file is simpler
and less error prone then modifying the consts_init() function, which should not need to be
touched.  Additionally changing it as you suggest would bulk up the consts_init() function
considerably.  However if still prefer me to change it as you suggest, I will do so.

> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Martin Walsh
>              Labels: hadoop
>         Attachments: HADOOP-7824.001.patch, HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating
systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message