Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 79A9B18422 for ; Mon, 29 Jun 2015 08:03:05 +0000 (UTC) Received: (qmail 89780 invoked by uid 500); 29 Jun 2015 08:03:05 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 89713 invoked by uid 500); 29 Jun 2015 08:03:05 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 89453 invoked by uid 99); 29 Jun 2015 08:03:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2015 08:03:05 +0000 Date: Mon, 29 Jun 2015 08:03:04 +0000 (UTC) From: "Kengo Seki (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-12142) Test code modification is not detected if test directory is at the top level of the project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kengo Seki updated HADOOP-12142: -------------------------------- Status: Patch Available (was: Open) > Test code modification is not detected if test directory is at the top level of the project > ------------------------------------------------------------------------------------------- > > Key: HADOOP-12142 > URL: https://issues.apache.org/jira/browse/HADOOP-12142 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Affects Versions: HADOOP-12111 > Reporter: Kengo Seki > Assignee: Kengo Seki > Attachments: HADOOP-12142.HADOOP-12111.01.patch > > > On HADOOP-12134, a sample patch contains test code modification, but test4tests failed to detect it. > This is because test directory is at the top level of the Pig project. test-patch detects changed files as follows, so the pattern does not match "test/...". > {code} > for i in ${CHANGED_FILES}; do > if [[ ${i} =~ /test/ ]]; then > ((testReferences=testReferences + 1)) > fi > done > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)